Fix the race condition that happens when in LOAD_AND_RESTORE mode and a user tries to configure a new network. #135
Conversation
…the AP we disable the wifi_manager_retry_timer to avoid a race condition.
mtetreault
changed the title
|
This PR should fix: @hqawasmi & @MPC-BlackBox: Could you please try this. It should fix your issue. Let me know if you still have some issues. |
|
@tonyp7: Are you still maintaining this project? Would you have the time to review this? |
|
Hello Matthieu, I wish I could tell you I was, but as you can clearly see nothing has moved for quite a while. I'm a new dad and moved place so I no longer have my electronics labs for now... If you would like to be part of the maintenance and auto-accept your PR let me know! |
|
|
||
|
|
||
| #include "json.h" | ||
| #include "dns_server.h" | ||
| #include "nvs_sync.h" | ||
| #include "wifi_manager.h" | ||
|
|
||
|
|
There was a problem hiding this comment.
I'm not too sure about this. It adds nothing useful. The build system will always define CONFIG_WIFI_MANAGER_DNS_SERVER_ENABLE
There was a problem hiding this comment.
You should define the build time variables as per wifi_manager.h which is best practice. No need to define a new global byte.
There was a problem hiding this comment.
I'll have to validate, from what I remember when set to 'n' `CONFIG_WIFI_MANAGER_DNS_SERVER_ENABLE' was simply undefined. That why I check if it's defined or not.
You're right though, this should be in wifi_manager.h.
Congrats on you new born, if I extrapolate, he/she is about a year old right? If you don't mind, I would love to help you maintain this repository:) |
The DNS server is, in some use cases, unwanted. I added the possibility to disable it as required. By default it is enable, so it doesn't change the actual behavior.
My use case is the following. I have a mobile application that configure the wifi and do the pairing with Google IOT. Having the dns server was not useless.
I also moved assets and web files to folders.