Add support for bookmarked locations #549
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
More progress, there is now a bookmark layer and open and save actions (to comma-separated values, tab-delimited values, and simple JSON files). Still left to do are refresh-layer-on-edit and a context menu for creating bookmarks at the current mouse location. |
|
|
heuermh
force-pushed
the
bookmark-layer
branch
from
12df2d7 to
2bf3475
Compare
|
Rebased |
|
Rebased and squashed commits |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another work in progress draft pull request, this one towards adding support for bookmarked locations. So far I have created the dialogs for managing an
EventList<Bookmark>, see screenshots attached below for a list view and a table view.I would next like to add a new bookmarks layer on the map and the context menu for creating bookmarks from the current mouse location, but it will take me a bit to grok the layer and drawer APIs.
See #235, #119, #475