Rename ToolsDB data source

[dhinus]

The current database name is wrong, the real database name is specified in the connection URL and is "information_schema".

As discussed in the Phab task, it makes sense to call this data source simply "ToolsDB" and let users select their desired database in their SQL queries.

Bug: T367393

[dhinus]

@vivian-rook thanks for approving! Will you take care of merging & deploying this, or should I do it? This is not urgent by the way, it can wait a few days.

[dhinus]

@vivian-rook I see that T372395 is now resolved, can I try deploying this PR with deploy.sh?

[vivian-rook]

@vivian-rook I see that T372395 is now resolved, can I try deploying this PR with deploy.sh?

Go for it!

[dhinus]

I deployed this PR, I can see the new name, but the old one is also there:

[vivian-rook]

Might be hiding somewhere in the database. We could deploy a fresh system, that would probably remove the old entry.

[dhinus]

kubectl get configmap superset-extra-config -o yaml shows that the old name is no longer present in the k8s config.

@vivian-rook do you know why the old name is still showing in the UI, next to the new one?

[dhinus]

Sorry, I posted my comment before reading yours :)

[dhinus]

What's the procedure to deploy a fresh system? tofu destroy?

[vivian-rook]

For how it would be redeployed, it is poorly described in the README. It follows the same procedure in https://wikitech.wikimedia.org/wiki/PAWS/Admin#Blue_Green_Deployment then the database migrate steps described in the README

[dhinus]

Thanks! The UI issue is now fixed (did it require a full redeploy?), so I think this can be merged.

[vivian-rook]

Thanks! The UI issue is now fixed (did it require a full redeploy?), so I think this can be merged.

No a redeploy was not required. The database only had one dataset so the UI allowed me to remove it after removing the dataset (For some reason the UI won't allow you to remove objects that are integrated. Can get very problematic sometimes)