Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

注释调整、返回值调整、清理冗余 #2880

Open
wants to merge 4 commits into
base: 6.1
Choose a base branch
from
Open

注释调整、返回值调整、清理冗余 #2880

wants to merge 4 commits into from

Conversation

big-dream
Copy link
Contributor

  • 注释调整，实际为普通数组，非对象数组；
  • 返回值调整，void => null；
  • 清理冗余参数 $value；

@hongweipeng
Copy link
Member

image

如果注释返回是 @return Type[] ，对 IDE 貌似更友好。

@big-dream
Copy link
Contributor Author

image

如果注释返回是 @return Type[] ，对 IDE 貌似更友好。

因为 Input->options 就是普通数组，不是Option[] ，我在IDE使用$input->getOptions()获取全部选项然后去使用时，IDE会给出错误提示。
image

根据实际排查和阅读代码，Input->options 最多就算是mixed[]而不是Option[] 

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@big-dream @hongweipeng