-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: adding dummy commit to refresh scheduler #24
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Simon Paitrault <[email protected]>
Can you help me understand better what this does? Or rather, what is the problem that it solves? |
The issue that this GitHub action will solve is the issue with the current |
I see, thank you. Do you mind adding this info to the workflowfile itself (as a comment) so we readers. know what it's for? |
steps: | ||
- uses: actions/checkout@v3 | ||
with: | ||
token: ${{ secrets.ROBOT_PAT_TRIGGER_E2E_WORKFLOWS }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we need a PAT here. If default permissions of the default GITHUB_TOKEN
aren't enough, you can set contents
to write
and it should be enough.
https://docs.github.com/en/actions/security-guides/automatic-token-authentication
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The point of adding this PAT was to allow the commit to trigger workflow (which isn't the case when you checkout with the default one) but maybe we don't need this job to trigger workflow. I don't know if it gonna work as there is no documentation on that :x
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok interesting. But indeed we don't need to trigger a workflow here, we just need to update history so that the cronjob continues working.
Description
Add a github action to push a commit every 15 days in order to refresh the scheduler timeout.
PR Checklist: