Reinstate clipboard functionality #339
Conversation
| if (typeof children === 'undefined' || children === null) { | ||
| return | ||
| } | ||
| navigator.clipboard.writeText(children.toString()) |
There was a problem hiding this comment.
I'd consider waiting for permission returned from writeText resolves or rejects, and handle potential rejection.
| style={{ | ||
| cursor: 'pointer', | ||
| scale: copied ? `1.15` : `1`, | ||
| transition: 'scale 0.2s ease-in-out' |
There was a problem hiding this comment.
I'd suggest defining styles in scss file, to keep it consistent with other components
| @@ -6,6 +6,6 @@ export const getKeyCodeEvent = ( | |||
| ): KeyCodeEvent | undefined => { | |||
| return keyCodeEventValues.find( | |||
| keyCodeEvent => | |||
| keyCodeEvent.code === keyCode.code && keyCodeEvent.key === keyCode.key | |||
| keyCodeEvent.code === keyCode.code || keyCodeEvent.key === keyCode.key | |||
There was a problem hiding this comment.
Would you consider removing that change here, and keep it in #338? That would make tracking it easier
| setCopied(true) | ||
| setTimeout(() => { | ||
| setCopied(false) | ||
| }, 200) |
There was a problem hiding this comment.
I think it would be nice to clear it on component unmount, WDYT?
There was a problem hiding this comment.
This is for an animation, so it needs to zoom out after quickly. Otherwise they would just stay scaled up until the component unmounts
|
Thanks - I really don’t have a ton of time for this, just hoping to restate the functionality the site had before I sold it. If it needs multiple components and tests just to write a string to clipboard, I guess we will just need to do without |
Fixes #336