feat: add sentry for error logging and information. #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Gaurav Goel <[email protected]>
| @@ -122,7 +125,7 @@ public static String[] getPublicKeyCoords(@NotNull String pubKey) throws TorusUt | |||
| if (publicKeyUnprefixed.length() <= 128) { | |||
| Common.padLeft(publicKeyUnprefixed, '0', 128); | |||
| } else { | |||
| throw new TorusUtilError("Invalid public key size"); | |||
| throw new TorusUtilError("Invalid public key size", TorusUtils.getClientId()); | |||
There was a problem hiding this comment.
Perhaps you can promote this to a full error, then it can sit will all the other errors. Will be easy to keep track of then, similary for the others like this.
|
@grvgoel81 Did you check that we can keep it the same way as here for swift as well? |
Yes it is. Reference: torusresearch/torus-utils-swift#107 |
Signed-off-by: Gaurav Goel <[email protected]>
Signed-off-by: Gaurav Goel <[email protected]>
Signed-off-by: Gaurav Goel <[email protected]>
| this.message = message; | ||
| } | ||
|
|
||
| private final String message; |
There was a problem hiding this comment.
This appears to be unused and can be removed, not so?
Signed-off-by: Gaurav Goel <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
Jira Link: https://toruslabs.atlassian.net/browse/PD-3897
Description
How has this been tested?
Screenshots (if appropriate):
Types of changes
Checklist: