-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make commitment request optional #163
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Release 15.0.0
update: add additional test cases
fix bs58 import
himanshuchawla009
changed the title
Feat remove commitments request
make commitment request optional
Sep 25, 2024
arch1995
approved these changes
Oct 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support added to make commitment request optional
Motivation and Context
This PR add supports to make commitment request optional. It does that by passing temp session keys and verifier to retrieve shares and import shares request.
Ideally this flow should be recommended only for mpc and multi factor setups. It should not be used in SFA flow.
This is done to improve login speed in cases where commitment request can be skipped.
Jira Link:
https://toruslabs.atlassian.net/browse/IRT-1536
Description
A new param named "checkCommitment" is added to
retrieveShares
andimportShares
function. By default its set totrue
to keep the change fully backward compatible.Apps can now set this flag to
false
if they want to skip commitment req.Previously session keys and verifier name was getting derived from node sigs in backend, this PR explicitly sends those fields in request if
checkCommitment
is set to false.How has this been tested?
A new test case is added to run the flow without commitments.
Also i have tested the network calls manually to see if its actually skipping the commitment rpc calls.
Similar testing has been done on backend.
Screenshots (if appropriate):
Types of changes
Checklist: