Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cleanup deps and minor code refactor #73

Closed
wants to merge 3 commits into from
Closed

cleanup deps and minor code refactor #73

wants to merge 3 commits into from

Conversation

himanshuchawla009
Copy link
Member

@himanshuchawla009 himanshuchawla009 commented Oct 10, 2024 •
edited
Loading

  • Removed unused deps
  • Removed db.ts file from tss client and moved to example, as it was only used in example
  • Refactored generateEndpoints functions to remove dep on static endpoints.
  • Fixed example
  • Update torus-scripts to use latest build config
  • Reordered code in client.ts file to meet linting criteria.
    ===================
    Note
  • Tested with prod example.

@himanshuchawla009 himanshuchawla009 changed the title cleanup deps and code cleanup deps and minor code refactor Oct 10, 2024
@himanshuchawla009 himanshuchawla009 changed the base branch from master to update_generate_endpoints October 10, 2024 11:56
@himanshuchawla009 himanshuchawla009 changed the base branch from update_generate_endpoints to master October 10, 2024 11:56
metalurgical
metalurgical reviewed Oct 10, 2024
View reviewed changes
packages/tss-client/src/utils.ts
@@ -112,21 +112,25 @@ export function getTSSPubKey(dkgPubKey: PointHex, userSharePubKey: key, userTSSI
return serverTerm.add(userTerm);
}

export const generateEndpoints = (parties: number, clientIndex: number) => {
export const generateEndpoints = (tssNodeEndpoints: string[], parties: number, clientIndex: number, nodeIndexes: number[]) => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See #70

@himanshuchawla009
Copy link
Member Author

closing it in the favour of #70

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@metalurgical metalurgical metalurgical left review comments

@matthiasgeihs matthiasgeihs Awaiting requested review from matthiasgeihs

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@himanshuchawla009 @metalurgical