Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Graphics now responsive #3

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Costava
Copy link
Contributor

@Costava Costava commented Oct 9, 2015

Comparison image

Graphics respond to size of window, rather than scaling a 320x480 canvas.

@towc
Copy link
Owner

towc commented Oct 9, 2015

why do you not want to keep the extra spaces in?

@Costava
Copy link
Contributor Author

Costava commented Oct 9, 2015

I apologize for the needless whitespace changes. I used Atom text editor for this work. The default behavior of Atom is to remove trailing whitespace. I now know that this can be toggled in the package settings for the 'whitespace' core package.

@Costava
Copy link
Contributor Author

Costava commented Oct 15, 2015

Is review for this PR planned for the weekend?

@towc
Copy link
Owner

towc commented Oct 16, 2015

@Costava this is not even a serious game. It was just a little thing I did over a few days for js13kgames.com
What are you aiming at? If it's only for hacktober, the PRs can be in any state (requested, rejected, accepted), they still count ;

@Costava
Copy link
Contributor Author

Costava commented Oct 17, 2015

@towc The game caught my eye in js13k. I have not seen a game before with this mechanic. It stood out to me that the graphics were blurry because it looks like everything can be paths and text, so I thought it would be a good thing to work on for Hacktoberfest. I learned new things from the process and your code. I would appreciate it if you could review this sometime.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants