Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use workspace dependencies for tower #778

Merged
merged 5 commits into from
Jul 23, 2024

Conversation

GlenDC
Copy link
Contributor

@GlenDC GlenDC commented Jul 22, 2024

Closes #776

@GlenDC
Copy link
Contributor Author

GlenDC commented Jul 22, 2024

@tobz this would require a MSRV bump to 1.64 (currently it is 1.63): https://github.com/rust-lang/cargo/blob/master/CHANGELOG.md#cargo-164-2022-09-22

@tobz
Copy link
Member

tobz commented Jul 22, 2024

Seems fine to bump: 1.64 is still from September 2022 so we're far far ahead of the support window goal.

@GlenDC
Copy link
Contributor Author

GlenDC commented Jul 22, 2024

Seems fine to bump: 1.64 is still from September 2022 so we're far far ahead of the support window goal.

@tobz
Copy link
Member

tobz commented Jul 23, 2024

Just fixed some conflicts and made some small tweaks in the process, namely using the short-form of the dtolnay/rust-toolchain action where you can pass the Rust toolchain version as the action version (i.e., you get the stable toolchain by using dtolnay/rust-toolchain@stable)

@tobz tobz merged commit 85080a5 into tower-rs:master Jul 23, 2024
14 checks passed
@jplatte jplatte mentioned this pull request Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

use workspace dependencies
2 participants