-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/dark mode UI v2 #309
base: releaseCandidate
Are you sure you want to change the base?
Feature/dark mode UI v2 #309
Conversation
… all data' instead
…life for reusability
…n for options main page with popup (and viceversa)
…eature wouldn't work
bbcc807
to
6b14f35
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
merged and checked
@tprouvot I think I've found an issue currently on the live version (which is breaking the test-framework) |
Hi @Astisme , |
ok, that's all. |
Hi @Astisme,
Popup, lots of differences in REST Explore page, Event Monitor, Field Creator |
Can you expand on this?
Do you mean that a user who wants dark mode, should switch to it for every new session? |
What do you expect to happen when disabling the option?
At the moment, it should stop to follow your browser's theme appearance. What is happening to you? I do not have a Mac to test this on, unfortunately. |
Sorry for these
I've rushed them last minute since they weren't available before. |
follow-system.online-video-cutter.com.mp4 |
Describe your changes
Complete overhaul to implement dark mode on every page.
This inlcudes the following:
Ability to switch to light/dark mode from within the popupAbility to switch to light/dark mode from the options page
Ability to pick between default and accent mode form within the options page
Synchronization of theme & accent between any inspector page and any other inspector page (including popup)
Load of page with the latest theme and accent (
fast-theme.js
)New styling for inspector button (need
inspector.css
in the manifest) when theme != light && accent != defaultWhile I was working on CSS,
While I was trying to test on Firefox,
links.js
not being recognized as a module (removed from the manifest and renamed tolinks.mjs
)Updated the readme.md with the newest command for thesf
cli.Issue ticket number and link
Issue #64
Checklist before requesting a review