Tensor type indent fix #2196
Merged
Tensor type indent fix #2196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2196 +/- ##
==========================================
+ Coverage 86.04% 86.08% +0.03%
==========================================
Files 695 695
Lines 88882 89002 +120
==========================================
+ Hits 76480 76618 +138
+ Misses 12402 12384 -18 ☔ View full report in Codecov by Sentry. |
antimora
approved these changes
Aug 23, 2024
Comment on lines
771
to
781
| fn get_input_values(node: &Node, index: usize) -> Vec<i64> { | ||
| // If the input is not provided, return an empty vector | ||
| if node.inputs.get(index).is_none() { | ||
| return Vec::new(); | ||
| } | ||
|
|
||
| match &node.inputs[index].value { | ||
| Some(Data::Int64s(shape)) => shape.clone(), | ||
| _ => panic!("Tensor data type must be int64"), | ||
| } | ||
| } |
There was a problem hiding this comment.
Did you intend to include pad related changes? I see you have #2195 open. Perhaps, this is based on that branch and that's why these changes appear?
There was a problem hiding this comment.
Yeah, I had to make the pad related changes in order to test the user model.
laggui
reviewed
Aug 23, 2024
laggui
approved these changes
Aug 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Checklist
run-checks allscript has been executed.Related Issues/PRs
#2151
#2115
Dependant on #2195
Changes
If a TensorType name is a number, adding _ in front to make it a valid Ident for proc_macro2
Testing
Ran user model mentionned in #2151