Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(openai): add nested function key to tool_calls #1520

Closed
wants to merge 1 commit into from
Closed

refactor(openai): add nested function key to tool_calls #1520

wants to merge 1 commit into from

Conversation

achang97
Copy link
Contributor

  • I have added tests that cover my changes.
  • If adding a new instrumentation or changing an existing one, I've added screenshots from some observability platform showing the change.
  • PR name follows conventional commits format: feat(instrumentation): ... or fix(instrumentation): ....
  • (If applicable) I have updated the documentation accordingly.

@achang97 achang97 force-pushed the standardize-tool-calls branch from 4914b4d to e901c3c Compare July 18, 2024 22:13
@nirga
Copy link
Member

nirga commented Jul 19, 2024

This introduces a breaking change, and given that we have another breaking change coming soon which is the approved semantic convention I don't think we should merge this as of now.

@nirga nirga closed this Jul 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@achang97 @nirga