Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ember values to Artifacts.json #28

Merged
merged 1 commit into from
Dec 20, 2024
Merged

Conversation

4Ply
Copy link
Member

@4Ply 4Ply commented Dec 20, 2024

This is used by Citadel to sort the artifakes view.

Also I replaced tabs with spaces, so review with this setting enabled:

image

@4Ply 4Ply marked this pull request as ready for review December 20, 2024 18:10
@Frustrated-Programmer
Copy link
Member

You prefer spaces over tabs 😳😮

Also. No need to update brilliance version, the json files aren't used in the datapack at all and was primarily used for my scripts I used to automate certain files. But now they just dev files

@Frustrated-Programmer Frustrated-Programmer merged commit 651592c into main Dec 20, 2024
1 check passed
@4Ply
Copy link
Member Author

4Ply commented Dec 20, 2024

Yes I do! And spaces are the standard for json files ;)

@4Ply 4Ply deleted the add-ember-values branch December 20, 2024 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants