Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add icon to strategy header #598

Merged
merged 6 commits into from
Sep 27, 2023
Merged

Add icon to strategy header #598

merged 6 commits into from
Sep 27, 2023

Conversation

allozaur
Copy link
Contributor

@allozaur allozaur commented Sep 26, 2023 •
edited
Loading

Close #490

@allozaur allozaur requested a review from kenkunz September 26, 2023 12:04
@kenkunz
use strategy icon_url
8761db0
@kenkunz
fix broken strategy error formatting
ae7f535
@kenkunz
move heading strategy icon into PageHeading component
8c3e368
@kenkunz
fix strategy PageHeading responsive/mobile formatting
001a299 
- adjust layout of image on small screens
- adjust font sizing and spacings on small screens
- refactor to use optional props/slots
kenkunz
kenkunz approved these changes Sep 27, 2023
View reviewed changes
Copy link
Contributor

@kenkunz kenkunz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fixed some issues with error styling and responsive / mobile styling.

@kenkunz kenkunz merged commit c6a6708 into master Sep 27, 2023
3 checks passed
@kenkunz kenkunz deleted the 490-add-icon-to-strategy-header branch September 27, 2023 20:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kenkunz kenkunz kenkunz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add icon to strategy header
2 participants
@allozaur @kenkunz