Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix trade null price_structure error #627

Merged
merged 2 commits into from
Nov 21, 2023
Merged

Conversation

kenkunz
Copy link
Contributor

@kenkunz kenkunz commented Nov 21, 2023

fixes #626

  • fix trade details error when price_structure=null
  • add type predicates for trade route and other param matchers

- improve TradeExecution interface
- add integer param matcher with type predicate
- rename trade routes to use param matcher / type predicate
@kenkunz kenkunz merged commit 568cbcc into master Nov 21, 2023
4 checks passed
@kenkunz kenkunz deleted the 626-fix-trade-details-bug branch November 21, 2023 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Individual trades not showing up
1 participant