Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better out of gas handlign when broadcasting #181

Merged
merged 7 commits into from
Dec 12, 2023
Merged

Better out of gas handlign when broadcasting #181

merged 7 commits into from
Dec 12, 2023

Conversation

miohtama
Copy link
Contributor

@miohtama miohtama commented Dec 12, 2023 •
edited
Loading

  • Fix: HotWallet.sign_bound_call_with_new_nonce tries to avoid calling broken Web3 gas estimation
    machine if the gas parameters are already given as the arguments
  • Fix: Raise OutOfGasFunds in _broadcast_multiple_nodes and
    avoid transaction broadcast retry if we do not have gas money
  • Fix: Don't swallow nonce errors and chain id errors in broadcast_multiple_nodes

@miohtama miohtama merged commit d8b6271 into master Dec 12, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@miohtama