Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: integration web3-google-hsm module to sign txs using gcp HSM key… #259

Closed
wants to merge 3 commits into from
Closed

feat: integration web3-google-hsm module to sign txs using gcp HSM key… #259

wants to merge 3 commits into from

Conversation

Aviksaikat
Copy link

  • feat: integration web3-google-hsm module to sign txs using gcp HSM key
  • test: tests added

miohtama
miohtama requested changes Jan 7, 2025
View reviewed changes
Copy link
Contributor

@miohtama miohtama left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good!

I added few comments on which tokens to use and how to streamline/remove some of code.

tests/test_hsm_hotwallet.py Show resolved Hide resolved
tests/test_hsm_hotwallet.py Show resolved Hide resolved
tests/test_hsm_hotwallet.py Show resolved Hide resolved
tests/test_hsm_hotwallet.py Show resolved Hide resolved
eth_defi/hsm_hotwallet.py
@@ -0,0 +1,474 @@
"""HSM wallet management utilities.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to add new files to docs/source indexes, as currently Sphinx cannot pick up all stuff automatically.

@Aviksaikat Aviksaikat closed this Jan 8, 2025
@Aviksaikat Aviksaikat deleted the feat/web3/hsm branch January 8, 2025 06:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miohtama miohtama miohtama requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Aviksaikat @miohtama