Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added custom outputs binary state methods #64

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

elShiaLabeouf
Copy link

Please see Issue#63

@apotonick
Copy link
Member

Two problems here:

  1. You're changing Result's public API! 😬
  2. The activity argument couples Result strongly to Activity.

Why don't you simply add a module (so your behavior is optional) that monkey-patches Result and, if called with semantic_name? checks if signal's :semantic field matches? Much easier, right?

But at least you know a lot more about the Activity API now!!! 👏 😆

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants