Skip to content

Commit

Permalink
Fix specs
Browse files Browse the repository at this point in the history
  • Loading branch information
nid90 committed Nov 14, 2024
1 parent c12fd96 commit c0d6310
Show file tree
Hide file tree
Showing 4 changed files with 8 additions and 1 deletion.
2 changes: 1 addition & 1 deletion spec/factories/google_firebase_submissions.rb
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
}

trait :with_store_release do
store_release { {"id" => 1} }
store_release { {"id" => "projects/#{Faker::Number.number(digits: 8)}/apps/#{Faker::Lorem.word}/releases/1"} }
end

trait :preprocessing do
Expand Down
1 change: 1 addition & 0 deletions spec/models/play_store_submission_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,7 @@
before do
allow_any_instance_of(described_class).to receive(:provider).and_return(providable_dbl)
allow(providable_dbl).to receive(:public_icon_img)
allow(providable_dbl).to receive(:project_link)
allow(StoreSubmissions::PlayStore::UpdateExternalReleaseJob).to receive(:perform_later)
end

Expand Down
2 changes: 2 additions & 0 deletions spec/models/pre_prod_release_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,8 @@
before do
allow_any_instance_of(PlayStoreSubmission).to receive(:provider).and_return(providable_dbl)
allow(providable_dbl).to receive(:find_build).and_return(true)
allow(providable_dbl).to receive(:public_icon_img)
allow(providable_dbl).to receive(:project_link)
end

it "triggers the next submission" do
Expand Down
4 changes: 4 additions & 0 deletions spec/models/test_flight_submission_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,8 @@
before do
allow(provider_dbl).to receive(:update_release_notes)
allow(provider_dbl).to receive(:find_build).and_return(GitHub::Result.new { build_info })
allow(provider_dbl).to receive(:public_icon_img)
allow(provider_dbl).to receive(:project_link)
allow(StoreSubmissions::TestFlight::UpdateBuildNotesJob).to receive(:perform_later)
end

Expand Down Expand Up @@ -143,6 +145,8 @@

before do
allow(provider_dbl).to receive(:find_build).and_return(GitHub::Result.new { in_progress_build_info })
allow(provider_dbl).to receive(:public_icon_img)
allow(provider_dbl).to receive(:project_link)
end

it "raises error when build is not in terminal state" do
Expand Down

0 comments on commit c0d6310

Please sign in to comment.