Skip to content
This repository has been archived by the owner on Sep 23, 2024. It is now read-only.

fix - Add default schema name to S3 archive metadata #339

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

GtheSheep
Copy link

@GtheSheep GtheSheep commented Jan 3, 2023

Problem

Closes same issue as Pipeline fails if archive enabled with s3 and tap table name is not in format <<schema_name>>__<

>

Proposed changes

Add a default schema_name to the S3 metadata, also happy to just set this to an empty string if you prefer? or perform in the metadata function itself

Types of changes

What types of changes does your code introduce to PipelineWise?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

  • Description above provides context of the change
  • I have added tests that prove my fix is effective or that my feature works
  • Unit tests for changes (not needed for documentation changes)
  • CI checks pass with my changes
  • Bumping version in setup.py is an individual PR and not mixed with feature or bugfix PRs
  • Commit message/PR title starts with [AP-NNNN] (if applicable. AP-NNNN = JIRA ID)
  • Branch name starts with AP-NNN (if applicable. AP-NNN = JIRA ID)
  • Commits follow "How to write a good git commit message"
  • Relevant documentation is updated including usage instructions

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant