Make sure weekly runs happen

transitmatters · Sep 4, 2024 · d896e18 · d896e18
1 parent 7ff1e5f
commit d896e18
Show file tree

Hide file tree

Showing 3 changed files with 26 additions and 4 deletions.
diff --git a/ingestor/.chalice/resources.json b/ingestor/.chalice/resources.json
@@ -199,6 +199,27 @@
         }
       }
     },
+    "UpdateAlertDelays": {
+      "Type": "AWS::Serverless::Function",
+      "Properties": {
+        "Environment": {
+          "Variables": {
+            "DD_API_KEY": {
+              "Ref": "DDApiKey"
+            },
+            "DD_VERSION": {
+              "Ref": "GitVersion"
+            },
+            "DD_TAGS": {
+              "Ref": "DDTags"
+            },
+            "DD_GIT_REPOSITORY_URL": {
+              "Ref": "DDGitRepositoryUrl"
+            }
+          }
+        }
+      }
+    },
     "UpdateDeliveredTripMetricsYesterday": {
       "Type": "AWS::Serverless::Function",
       "Properties": {

diff --git a/ingestor/app.py b/ingestor/app.py
@@ -108,7 +108,8 @@ def update_time_predictions(event):
 
 
 # 7:45am UTC -> 2:45/3:45am ET every Monday
-@app.schedule(Cron(45, 7, "*", "*", "1", "*"))
+# There's no benefit to running it more frequently than once a week.
+@app.schedule(Cron(45, 7, "?", "*", "MON", "*"))
 def update_alert_delays(event):
     today = datetime.now()
     one_week_ago = (today - timedelta(days=8)).date()

diff --git a/ingestor/chalicelib/delays/process.py b/ingestor/chalicelib/delays/process.py
@@ -8,9 +8,9 @@
 import pandas as pd
 import requests
 
-from ingestor.chalicelib import constants, dynamo
-from ingestor.chalicelib.delays.aggregate import group_weekly_data
-from ingestor.chalicelib.delays.types import Alert, AlertsRequest
+from chalicelib import constants, dynamo
+from chalicelib.delays.aggregate import group_weekly_data
+from chalicelib.delays.types import Alert, AlertsRequest
 
 TABLE_NAME = "AlertDelaysWeekly"