Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Blue Line to README.md #149

Closed
wants to merge 2 commits into from
Closed

Add Blue Line to README.md #149

wants to merge 2 commits into from

Conversation

nekodjin
Copy link

Correct the README to reflect that a Blue Line tracker has been added to the app.

@github-actions github-actions bot added the documentation Improvements or additions to documentation label Jul 19, 2023
Copy link
Member

@devinmatte devinmatte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for making a PR! I think this whole sentence could use a rewrite as we show new Orange, Red and Green line cars, and we additionally show Blue line cars, but there are no "new" blue line cars to show or track. If you want to take a crack at rewriting this to be more clear on that point that would be great

@nekodjin
Copy link
Author

nekodjin commented Aug 1, 2023

How about something along the lines of:

The tracker shows the current location of Orange, Red, Green, and Blue Line trains on the MBTA network. It shows which Red and Green Line trains are new, and which are old.

It doesn't really make sense to include the OL, since just as the BL has no "new" trains, the OL no longer has any "old" ones...

@mathcolo
Copy link
Contributor

@nekodjin That would work! Could you make that change to your branch?

@nekodjin
Copy link
Author

On it by tomorrow :)

@nathan-weinberg
Copy link
Member

@nekodjin Hey! We'd still be interested in getting that change in if you can make the suggested update 😄

@nathan-weinberg
Copy link
Member

Since this seems to be abandoned I'm going to close this for now - @nekodjin if you're able to come back around and update your branch feel free to reopen it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants