[v3] hide secrets in healthcheck output (#697)

transitmatters · Jun 24, 2023 · 3d4f02b · 3d4f02b
1 parent d2aa01b
commit 3d4f02b
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/server/app.py b/server/app.py
@@ -49,7 +49,10 @@ def healthcheck():
             if not check_bool:
                 failed_checks[check] = "Check failed :("
         except Exception as e:
-            failed_checks[check] = f"Check threw an exception: {e}"
+            e_str = str(e)
+            for secret in secrets.HEALTHCHECK_HIDE_SECRETS:
+                e_str.replace(secret, "HIDDEN")
+            failed_checks[check] = f"Check threw an exception: {e_str}"
 
     if len(failed_checks) == 0:
         return Response(body={

diff --git a/server/chalicelib/secrets.py b/server/chalicelib/secrets.py
@@ -2,3 +2,8 @@
 
 MBTA_V2_API_KEY = os.environ.get("MBTA_V2_API_KEY", "")
 MBTA_V3_API_KEY = os.environ.get("MBTA_V3_API_KEY", "")
+
+HEALTHCHECK_HIDE_SECRETS = [
+    MBTA_V2_API_KEY,
+    MBTA_V3_API_KEY
+]