V4.1/Accessibility alerts #578

kmoses228 · 2023-05-16T17:30:38Z

Motivation

Related to #562

We are not currently showing any data related to accessibility on the dashboard, however this is essential for riders who, for example, cannot use stairs. We also want to hold the MBTA accountable for fixing these issues in a timely manner and keeping accessible features in good working order.

Changes

This PR adds accessibility alerts to the "Today" dashboard for each subway line. Users can click on the alert to see the full description and workaround, if available.

I've also added an /api/facilities endpoint for fetching all elevators and escalators on a line. This is not in use yet but will be in the future.

The next PR will focus on adding a historical dashboard for elevator and escalator downtime per-line.

Testing Instructions

Run the branch locally and interact with the alerts on each line. Also soliciting feedback on the design.

devinmatte

So firstly, this is awesome. Thanks for working on this so quickly. We clearly can deliver some real value (and pressure) in v4 with this.

I do have some thoughts on the way we display this data. It's a little busy on lines like the red line. I think this might work better somehow placed on the Trips page and displaying info for the two stations selected AND/OR displaying some kind of aggregate on the Today page. Maybe combining alerts into one and saying

Elevators out of service at: JFK/UMASS, Park Street & South Station
Or
40/45 elevators in service across line

At a minimum, I think we can remove the Upcoming part of the widget since I don't think they generally plan elevator downtime far in advance, and if they are planning, it's likely for repairs, and we don't need to be critical of the T for doing the right thing

devinmatte · 2023-05-16T19:02:15Z

modules/dashboard/Today.tsx

          {canShowSlowZonesMap && <Speed />}
+          <Alerts title="Accessibility" alerts={accessibilityAlerts} />


I think if we're going to reuse alerts here, we should add some kind of prop that get's rid of the today and upcoming sections, because we probably only care about current accessibility alerts

PatrickCleary · 2023-06-19T15:12:32Z

Looks great. Sorry for the delay, we were in full "finish v4" mode. We ended up reworking this page quite a bit as you may have seen.

I think we should get a group together and have a discussion about how we want to portray accessibility data. We could have a design session to talk about some ideas!

devinmatte · 2023-07-20T22:48:34Z

@kmoses228 Now that we've launched v4, it would be a good idea to readdress this and find a good spot for it

This reverts commit aec3030.

austinhouck · 2023-08-27T08:47:45Z

Screen.Recording.2023-08-27.at.4.46.49.AM.mov

idreyn · 2023-08-31T15:56:37Z

common/api/alerts.ts

+): Promise<AlertsResponse[]> => {
+  const url = new URL(`${APP_DATA_BASE_PATH}/api/alerts`, window.location.origin);
+
+  const lineStations = stations[route].stations;


We could consider factoring this into a utility like getStationsForLine() that performs this check.

idreyn · 2023-08-31T15:57:41Z

common/api/alerts.ts

+    stationKeys = lineStations.map((station: Station) => station.station);
+  }
+
+  const options = { ...accessibilityAlertsAPIConfig, stop: stationKeys.join(',') };


Also not a comment specific to this PR but I think we ought to have a utility function to handle this request setup for us, as we (myself included) have been duplicating it across these fns.

idreyn · 2023-08-31T15:58:32Z

common/api/facilities.ts

+export const fetchAllElevatorsAndEscalators = async (
+  line: LineShort
+): Promise<FacilitiesResponse> => {
+  const url = new URL(`${APP_DATA_BASE_PATH}/api/facilities`, window.location.origin);


Same here (@ALL) we could consider an apiFetch() helper to handle the base path, params, etc.

idreyn · 2023-08-31T15:59:41Z

common/types/facilities.ts

+}
+
+export interface Facility {
+  type: string;


Is there a known set of possible values here?

It seems like it can only be facility, I'll change this.

idreyn · 2023-08-31T16:01:29Z

common/types/stations.ts

@@ -20,6 +20,10 @@ export interface Station {
  short?: string;
 }

+export const isLineMap = (obj: LineMap | Station[]): obj is LineMap => {


Another suggestion for code structure over time (no need to address here): I think we could find a better name for the LineMap type, especially since we now have more map-related code elsehwere in the codebase. Maybe RouteDescription?

idreyn · 2023-08-31T16:02:28Z

modules/commute/alerts/AccessibilityAlert.tsx

+}
+
+export const AccessibilityAlert: React.FC<DelayAlertProps> = ({ alert, type, lineShort }) => {
+  const lineStations = stations[lineShort].stations;


Here's another place where getStationsForLine() would be nifty.

idreyn · 2023-08-31T16:02:53Z

modules/commute/alerts/AccessibilityAlert.tsx

+    >
+      <span>
+        {alert.type === AlertEffect.ESCALATOR_CLOSURE
+          ? 'Escalator out of service'


Consider factoring out the inner string calculation for clarity.

idreyn · 2023-08-31T16:03:49Z

modules/commute/alerts/AlertBox.tsx

-          {relevantAlerts.map((alert: FormattedAlert) =>
-            getAlertComponent(alert, lineShort, type, busRoute)
-          )}
+          {relevantAlerts


Could we move the calculation of this array into a useMemo()? a JSON.stringify() is a somewhat expensive operation to do on every render.

Not even really sure why this is here, I'll just remove it

idreyn · 2023-08-31T16:04:50Z

modules/commute/alerts/Time.tsx

@@ -70,3 +70,13 @@ export const UpcomingTime: React.FC<TimeProps> = ({ times }) => {
    </>
  );
 };
+
+export const SinceTime: React.FC<TimeProps> = ({ times }) => {


I think either name is fine but I wonder if we should use TimeSince to match the showTimeSince prop elsewhere.

Changing to EffectiveTime

idreyn · 2023-08-31T16:06:09Z

modules/dashboard/Overview.tsx

  return (
    <PageWrapper pageTitle={'Overview'}>
      <div className="grid w-full grid-cols-1 gap-4 md:gap-8 xl:grid-cols-2">
+        {tab === 'Subway' && lineShort && <AlertsWidget lineShort={lineShort} />}


❗️ I think this should go at the bottom. It's good to have this on the overview page, but I don't think we want it to push the graphs down below the fold on mobile.

idreyn

This looks great to me and I think we should land it as soon as possible! (Sorry for letting it languish a bit).

I do think we probably want to put the alerts below the graphs on the Line Overview page. Thoughts, all?

idreyn

This looks great to me and I think we should land it as soon as possible! (Sorry for letting it languish a bit).

I do think we probably want to put the alerts below the graphs on the Line Overview page. Thoughts, all?

PatrickCleary · 2023-08-31T16:32:27Z

Looks great, I'm excited to get this in. Thanks Austin and Kevin.

I have a few minor suggestions:

I agree with Ian, this should be below the graphs (or just smaller).
I don't think this belongs in a separate page. It's all real-time data, so it doesn't adhere to the date configurations. It can just be on the overview I think.
I believe we don't need the upcoming section for accessibility. I don't think they are posted in advance generally? Not certain.

devinmatte · 2023-09-07T13:38:58Z

I'm with @PatrickCleary in thinking we don't need a separate Alerts page right now. I think we could make something like this but for now I think these living exclusively on the overview page is fine by me

Kevin Moses added 9 commits May 15, 2023 16:47

Fetch facilities by line

0b8e4b7

Fix errors

bb23762

Add types

d535f5a

Merge branch 'dashboard-v4' into v4-accessability

2f2715f

Rename

b9593fe

Another rename

cc4a48d

Render accessibility alerts

fadb7f5

Improve alert rendering

aa09d27

Lint

d21782d

kmoses228 requested review from austinjpaul, skaplan-dev, devinmatte and PatrickCleary as code owners May 16, 2023 17:30

github-actions bot added backend Change to backend code frontend Change to frontend code labels May 16, 2023

Bold station names

0a6e640

devinmatte reviewed May 16, 2023

View reviewed changes

kmoses228 changed the title ~~V4/Accessibility alerts~~ V4.1/Accessibility alerts May 31, 2023

kmoses228 added this to the Dashboard V4.1 milestone May 31, 2023

devinmatte added the v4 label Jun 3, 2023

Base automatically changed from dashboard-v4 to main July 17, 2023 16:11

idreyn requested review from idreyn and mathcolo as code owners July 17, 2023 16:11

nathan-weinberg removed the v4 label Jul 18, 2023

austinhouck added 4 commits July 28, 2023 01:32

Merge remote-tracking branch 'origin/main' into v4-accessibility

cc828f8

Moving Alerts to Overview

aec3030

Revert "Moving Alerts to Overview"

d253624

This reverts commit aec3030.

Merge remote-tracking branch 'origin/main' into v4-accessibility

1684048

austinhouck and others added 3 commits August 27, 2023 03:52

Merge branch 'main' into v4-accessibility

0df99fd

Try Again

0e2cf00

Update mbta_v3.py

5b05905

idreyn reviewed Aug 31, 2023

View reviewed changes

idreyn approved these changes Aug 31, 2023

View reviewed changes

austinhouck and others added 2 commits September 7, 2023 01:20

Merge branch 'main' into v4-accessibility

c708b09

Comments

d62172a

Removing Alerts Page

33b1c8f

austinhouck merged commit d742188 into main Sep 8, 2023
5 checks passed

austinhouck deleted the v4-accessibility branch September 8, 2023 01:40

nathan-weinberg mentioned this pull request Feb 16, 2024

Show running elevators/escalators #562

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

V4.1/Accessibility alerts #578

V4.1/Accessibility alerts #578

kmoses228 commented May 16, 2023 •

edited

Loading

devinmatte left a comment

devinmatte May 16, 2023

PatrickCleary commented Jun 19, 2023

devinmatte commented Jul 20, 2023

austinhouck commented Aug 27, 2023

idreyn Aug 31, 2023

idreyn Aug 31, 2023

austinhouck Sep 7, 2023

idreyn Aug 31, 2023

austinhouck Sep 7, 2023

idreyn Aug 31, 2023

austinhouck Sep 7, 2023

idreyn Aug 31, 2023 •

edited

Loading

idreyn Aug 31, 2023

idreyn Aug 31, 2023

idreyn Aug 31, 2023

austinhouck Sep 7, 2023

idreyn Aug 31, 2023

austinhouck Sep 7, 2023

idreyn Aug 31, 2023

idreyn left a comment

idreyn left a comment

PatrickCleary commented Aug 31, 2023

devinmatte commented Sep 7, 2023

		{canShowSlowZonesMap && <Speed />}
		<Alerts title="Accessibility" alerts={accessibilityAlerts} />

V4.1/Accessibility alerts #578

V4.1/Accessibility alerts #578

Conversation

kmoses228 commented May 16, 2023 • edited Loading

Motivation

Changes

Testing Instructions

devinmatte left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

PatrickCleary commented Jun 19, 2023

devinmatte commented Jul 20, 2023

austinhouck commented Aug 27, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

idreyn Aug 31, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

idreyn left a comment

Choose a reason for hiding this comment

idreyn left a comment

Choose a reason for hiding this comment

PatrickCleary commented Aug 31, 2023

devinmatte commented Sep 7, 2023

kmoses228 commented May 16, 2023 •

edited

Loading

idreyn Aug 31, 2023 •

edited

Loading