Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing total slow time tooltip label #723

Merged
merged 3 commits into from
Jul 7, 2023
Merged

Fixing total slow time tooltip label #723

merged 3 commits into from
Jul 7, 2023

Conversation

devinmatte
Copy link
Member

Motivation

#634

Changes

Screenshot 2023-07-07 at 1 23 18 PM

Testing Instructions

@devinmatte devinmatte added the v4 label Jul 7, 2023
@devinmatte devinmatte added this to the Dashboard V4 milestone Jul 7, 2023
@devinmatte devinmatte self-assigned this Jul 7, 2023
@github-actions github-actions bot added the frontend Change to frontend code label Jul 7, 2023
PatrickCleary
PatrickCleary approved these changes Jul 7, 2023
View reviewed changes
Copy link
Member

@PatrickCleary PatrickCleary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Opened a PR on this with some nits on casing

@devinmatte devinmatte merged commit 6733fc3 into dashboard-v4 Jul 7, 2023
5 checks passed
@devinmatte devinmatte deleted the v4/total-slow-label branch July 7, 2023 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PatrickCleary PatrickCleary PatrickCleary approved these changes

@austinjpaul austinjpaul Awaiting requested review from austinjpaul

@skaplan-dev skaplan-dev Awaiting requested review from skaplan-dev

Assignees

@devinmatte devinmatte

Labels
frontend Change to frontend code
Projects
Data Dashboard
Archived in project
Milestone
Dashboard V4
Development

Successfully merging this pull request may close these issues.
2 participants
@devinmatte @PatrickCleary