add histogram back #749
Merged
add histogram back #749
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PatrickCleary
requested review from
austinjpaul,
skaplan-dev and
devinmatte
as code owners
skaplan-dev
requested changes
Jul 12, 2023
There was a problem hiding this comment.
We should have this work irrespective of #748 (the whitespace)
|
I don't think that is realistic. To do that we need all the charts be the exact same height, which is the issue with the grid. |
devinmatte
reviewed
Jul 12, 2023
| <WidgetDiv> | ||
| <WidgetTitle | ||
| title="Headway histogram" | ||
| subtitle="Time spent at station" |
There was a problem hiding this comment.
This isn't correct, unless you mean "time rider spends at station waiting for train"
There was a problem hiding this comment.
whoops. Good catch.
|
I don't love using "histogram" in the visible display text. Maybe "distribution"? |
devinmatte
approved these changes
Jul 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Forgot to add the headways histogram back.
Changes
Adds headways histogram back.
Removing the grid in #748 which makes the whitespace at the botom go away.
Testing Instructions