Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Widget fix #763

Closed
wants to merge 4 commits into from
Closed

Widget fix #763

wants to merge 4 commits into from

Conversation

PatrickCleary
Copy link
Member

Motivation

There were a few people mentioning the widget slider button looked like a dropdown.

Changes

Make the widgets move right to left rather than down. Still looks kinda wack, and I have a longer term plan to improve, but I think this is better for short term.

Screen.Recording.2023-07-14.at.12.12.37.PM.mov

Make the widgets vertical on mobile and desktop. The horizontal was just way too cramped.
Screenshot 2023-07-14 at 12 12 54 PM

Testing Instructions

Scroll through widgets

@PatrickCleary PatrickCleary self-assigned this Jul 14, 2023
@github-actions github-actions bot added the frontend Change to frontend code label Jul 14, 2023
@PatrickCleary PatrickCleary added v4 and removed frontend Change to frontend code labels Jul 14, 2023
@PatrickCleary PatrickCleary added this to the Dashboard V4 milestone Jul 14, 2023
@PatrickCleary PatrickCleary marked this pull request as ready for review July 14, 2023 16:49
@devinmatte
Copy link
Member

If we have a arrow pointing left, could we not have one on the complete other side now pointing right? I feel like that might look nice and allow people to go back and forth on the stats and complete the look

@PatrickCleary
Copy link
Member Author

yea... That would be better. I am being kind of lazy, cuz if you do that you have to deal with where to place them. On the full screen graph it looks weird to have the arrow on the complete other side of the chart. If you have it hug the right side of the widget, then it moves around because they are variable widths.

I want to do something completely different for these tbh, but not enough time.

If this is too weird, I'm fine to keep the down arrow, but I don't think I have time to clean it up further. If you want to look into it though, feel free.

@devinmatte
Copy link
Member

I think it's fine to keep the down arrow. If people are confused at first. The second they click it, they're no longer confused, so I don't think we need to make this change now

@PatrickCleary
Copy link
Member Author

Okay, I'll remove that and keep the change to make all the widgets vertical

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants