Hit static landing page data #768
Conversation
github-actions
bot
added
dependencies
PatrickCleary
requested review from
austinjpaul,
skaplan-dev and
devinmatte
as code owners
modules/landing/LandingCharts.tsx
Outdated
| useQuery( | ||
| ['primer'], | ||
| () => | ||
| fetchActualTripsByLine({ |
There was a problem hiding this comment.
Thoughts about making this a query that might actually get called later so we can also benefit from the local cache? Right now this is under the key primer and therefore this cached call will never be used. Either remove the ONE_HOUR local cache or hit an endpoint with params/keys that might be called on a subsequent page
There was a problem hiding this comment.
I think that's an interesting point, and I was thinking about it for a bit. I think if we try to use a useful value, we're more likely to create more wasteful operations. We have no idea what the user is gonna do next, so the query is likely to end up not being used anyway.
I also think this solution is a bit hacky and I hope to have a better fix in the future, so I think keeping it clearly a "useless" function with the name primer reduces the odds that it causes confusion down the line. Whereas the performance benefits seem very minor at best.
There was a problem hiding this comment.
At least use useDeliveredTripMetrics with the set of params you used here, so the cache could be used
modules/landing/LandingCharts.tsx
Outdated
| useQuery( | ||
| ['primer'], | ||
| () => | ||
| fetchActualTripsByLine({ |
There was a problem hiding this comment.
At least use useDeliveredTripMetrics with the set of params you used here, so the cache could be used
Motivation
The landing page data was slow to load on the first query.
Changes
Fetch landing page data from
/staticfolder. Uploaded by a lambda in this pr: transitmatters/data-ingestion#33Add a "primer query" to landing page to get the lambdas warm for when the user goes to next page.
Testing Instructions
Check landing page -> make sure data is all there.