Remove v3 relic of 404s being a lie because of react router #770
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mathcolo
requested review from
austinjpaul,
skaplan-dev,
devinmatte and
PatrickCleary
as code owners
devinmatte
approved these changes
Jul 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
V3 relied on React Router to handle different URLs, and that worked because S3 returned the SPA for any request path. Next is more of a good citizen, in that it's generating actual files that are being served by S3/CloudFront. For that reason, we want the status code for 404s to ACTUALLY BE 404! :) Finally!
Changes
We're changing the 404 ResponseCode from 200 to 404. https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/aws-properties-cloudfront-distribution-customerrorresponse.html
Testing Instructions
Previous behavior:
Behavior after this is merged (anticipated);