fix: Render SZ segment labels properly in Safari #774
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
idreyn
requested review from
austinjpaul,
skaplan-dev,
devinmatte and
PatrickCleary
as code owners
idreyn
changed the title
devinmatte
approved these changes
Jul 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The time labels for Slow Zones map segments were previously rendered with the
<foreignobject>SVG element, which doesn't really work in Safari. This change renders them in pure SVG.Changes
SVG layout is pretty manual work and it was easiest to resort to Unicode characters for the directional arrows. I found that the ones that work best (i.e. have no weird subpixel glitches) are these chevron ones:
On mobile, though, we'll get a slightly different arrow look:
Testing Instructions
Visit
/red/slowzonesin desktop/mobile Safari and check that these elements render properly.