Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add v3/v4 file trick to make it OK that V3 paths don't have trailing slashes #778

Merged
merged 1 commit into from
Jul 16, 2023

Conversation

mathcolo
Copy link
Contributor

Motivation

Add v3/v4 file trick to make it OK that V3 paths don't have trailing slashes. Fixes #750

Changes

  • Add HTML pages (with no extension, but they have a Content type set, so it's OK!) at /rapidtransit, /bus, and /slowzones that have the sole purpose of redirecting to the trailing slash equivalent.

Testing Instructions

https://dashboard-beta.labs.transitmatters.org/rapidtransit?config=Red,70067,70071,2023-07-15,

should look the same as the v3 equiv:

https://dashboard.transitmatters.org/rapidtransit?config=Red,70067,70071,2023-07-15,

Copy link
Member

@PatrickCleary PatrickCleary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏

@mathcolo mathcolo merged commit 71bb933 into dashboard-v4 Jul 16, 2023
5 checks passed
@mathcolo mathcolo deleted the v4/v3_trick branch July 16, 2023 21:28
@devinmatte devinmatte added this to the Dashboard V4 milestone Jul 17, 2023
@devinmatte devinmatte added the v4 label Jul 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci/cd Affects or Updates CI/CD
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants