fix: Better SZ tooltip positioning #782
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
idreyn
requested review from
austinjpaul,
skaplan-dev,
devinmatte and
PatrickCleary
as code owners
idreyn
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Resolves #573 and #687
Changes
This changes moves the SZ tooltip to the left side of the map when there's more real estate for it there (e.g. on the Braintree branch). It also makes sure the tooltip is never hidden by the left-hand sidebar. I kept the tooltip beneath the mobile bottom controls, though — seems better; just scroll.
Testing Instructions
Check the tooltip rendering for the Red Line map on both desktop and mobile.