Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tweaks to chart format and colors #835

Merged
merged 4 commits into from
Aug 21, 2023
Merged

Tweaks to chart format and colors #835

merged 4 commits into from
Aug 21, 2023

Conversation

nathan-weinberg
Copy link
Member

@nathan-weinberg nathan-weinberg commented Aug 16, 2023 •
edited
Loading

Motivation

This PR makes some stylistic suggestions to the chart formatting and coloring as well as some minor tweaks to the Bug Template and Healthcheck action

Changes

image

  • Clarified that Version in Bug Template referred to Browser Version
  • Users can now trigger healthcheck action on demand
  • Updated Historic Maximums to include commas to match labels on vertical axis
  • Changed trips to Trips in Service graph to match other graphs' vertical axis
  • Changed Trips in Ridership graph to Riders
  • Added descriptor of Historic Maximum to all graphs for readability and consistency with the horizontal axis
  • Made MPH box background more white than gray to match the graph background

Testing Instructions

Deploy this PR locally

@github-actions github-actions bot added ci/cd Affects or Updates CI/CD frontend Change to frontend code labels Aug 16, 2023
@PatrickCleary
Copy link
Member

I would like to look at this more in-depth before it is merged. Just commenting so I don't forget.

PatrickCleary
PatrickCleary approved these changes Aug 18, 2023
View reviewed changes
Copy link
Member

@PatrickCleary PatrickCleary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this clean up.

Looks good to me. WRT the conversaation yesterday – I am a fan of using taps/validations/card taps for the unit of ridership over riders

But not too opinionated on which alternative to use.

modules/ridership/RidershipGraph.tsx Outdated
label: `Historical Maximum (${PEAK_RIDERSHIP[routeIndex ?? 'DEFAULT']})`,
label: `Historical Maximum (${PEAK_RIDERSHIP[
routeIndex ?? 'DEFAULT'
].toLocaleString('en-us')} riders)`,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this change. Do we want to also format as 213.7k riders like in the widget?
Screenshot 2023-08-18 at 1 13 01 PM

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Honestly I kinda like the k formatting but I'm open to changing it!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea, I'm saying have them both use K

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmmm I feel like the graph/axis it may make more sense to keep the exact number since that data is a bit more in-depth/granular than the overview, wdyt?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea, that's a good point. Works for me.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a "daily" or "weekly" label to It? In reading it, I can't figure out what the numbers mean. I know it's averaged weekly, but is it avg per day or total per week?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it not be the weekday average for the selected timeframe?

@nathan-weinberg
Copy link
Member Author

Made a few more changes based on feedback:

  • Changed some "rider" references to "fare validations"
  • Specified service is measured by round trips
  • Added comma formatting to ridership widget value

mathcolo
mathcolo reviewed Aug 20, 2023
View reviewed changes
common/types/basicWidgets.tsx Outdated Show resolved Hide resolved
common/types/basicWidgets.tsx Outdated Show resolved Hide resolved
modules/service/ServiceGraph.tsx Show resolved Hide resolved
@nathan-weinberg nathan-weinberg merged commit ae8b1d1 into transitmatters:main Aug 21, 2023
5 checks passed
@nathan-weinberg nathan-weinberg deleted the working branch August 21, 2023 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@austinjpaul austinjpaul austinjpaul left review comments

@PatrickCleary PatrickCleary PatrickCleary approved these changes

@mathcolo mathcolo mathcolo approved these changes

@skaplan-dev skaplan-dev skaplan-dev approved these changes

@idreyn idreyn Awaiting requested review from idreyn idreyn is a code owner

@devinmatte devinmatte Awaiting requested review from devinmatte devinmatte is a code owner

Assignees
No one assigned
Labels
ci/cd Affects or Updates CI/CD frontend Change to frontend code
Projects
Data Dashboard
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@nathan-weinberg @PatrickCleary @mathcolo @skaplan-dev @austinjpaul @devinmatte