Made v4 the default build version #836
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nathan-weinberg
requested review from
mathcolo,
idreyn,
skaplan-dev,
devinmatte and
PatrickCleary
as code owners
github-actions
bot
added
ci/cd
nathan-weinberg
force-pushed
the
build-update
branch
from
c0ae67e
to
60e2698
Compare
|
We probably don't need the v3 method anymore at all |
devinmatte
approved these changes
Aug 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Now that v4 has launched, it probably makes sense to make that the default
buildcommand and regulate v3 to a custom commandbuild-v3Changes
buildreferences changed tobuild-v3build-v4references changed tobuildTesting Instructions
Run new commands and compare