Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Align scheduled/delivered trip counts #993

Merged
merged 3 commits into from
Jun 19, 2024
Merged

Conversation

idreyn
Copy link
Contributor

@idreyn idreyn commented Jun 18, 2024

Motivation

I've noticed that the scheduled/delivered trip counts graph is getting out of sync. It turns out that we are missing a few data points for each line in the DeliveredTripMetricsWeekly table, which is causing the delivered array for a given date range to be a little shorter than the scheduled one. We should backfill these values, but in the meantime, I've added some code to make sure that the data points on those graphs are always aligned by day. This results in some "holes" in the graph. Maybe there was shuttling that should appear here?

Long term I there should be a single API that returns both scheduled and delivered trip counts in one shot, like /api/service_hours does.

Changes

Before:

Screenshot 2024-06-17 at 21-59-55 Service Data Dashboard

After:

Screenshot 2024-06-17 at 22-00-05 Service Data Dashboard

Testing Instructions

With "Past Year" time range selected, click through the Overview pages for each rapid transit line and verify that they load correctly and appear synchronized.

@github-actions github-actions bot added the frontend Change to frontend code label Jun 18, 2024
@idreyn idreyn merged commit 01d398b into main Jun 19, 2024
4 checks passed
@idreyn idreyn deleted the idr/align-service-graph branch June 19, 2024 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend Change to frontend code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants