Add a delays page for alert analysis #997
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
backend
github-actions
bot
added
ci/cd
idreyn
reviewed
Jun 25, 2024
| return ( | ||
| <ChartBorder> | ||
| <div className={classNames('h-72', 'flex w-full flex-row')}> | ||
| <Line |
There was a problem hiding this comment.
I'm curious if TimeSeriesChart.tsx would work for your purposes. I've been hoping we could consolidate some of the chart.js boilerplate into this component, and I had success using it for some of the newer service/ridership graphs. Not a big deal either way (but if you try it and find that it's not working somehow, I'd love to know why!)
|
This closes #986, right? |
|
Yep @rudiejd, that's the plan |
devinmatte
changed the title
devinmatte
requested review from
mathcolo,
nathan-weinberg,
austinjpaul,
skaplan-dev and
PatrickCleary
as code owners
skaplan-dev
approved these changes
Sep 20, 2024
|
Backend changes in #1011 to shrink this PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
#986
Keep track of what is keeping the MBTA from reliably delivering service on each line
Changes
Testing Instructions
Requires data from transitmatters/data-ingestion#104 and transitmatters/data-ingestion#113 before being merged