-
Notifications
You must be signed in to change notification settings - Fork 648
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
✨ V7 #225
Open
transmissions11
wants to merge
48
commits into
main
Choose a base branch
from
v7
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
✨ V7 #225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
transmissions11
commented
May 13, 2022
Co-authored-by: t11s <[email protected]>
Co-authored-by: t11s <[email protected]>
Co-authored-by: t11s <[email protected]>
* Optimize ERC-1155 JUMPs * ♻️ Cleanup * 📝 Dead comment Co-authored-by: t11s <[email protected]>
* Add calldata verify * Snapshot * Fix snapshot * Remove memory version of verify
todo rename MerkleProof to MerkleProofLib |
also needs better comments (details about assuming sortation n such https://github.com/OpenZeppelin/openzeppelin-contracts/blob/master/contracts/utils/cryptography/MerkleProof.sol) |
* Branchless last block * Edit comment
Co-authored-by: t11s <[email protected]>
* ✍️ correct comment on RLP encoding scheme * corrected comments * adjust comment on max account nonce * Update src/utils/LibRLP.sol * Update src/utils/LibRLP.sol * Update src/utils/LibRLP.sol * Update src/utils/LibRLP.sol --------- Co-authored-by: t11s <[email protected]>
Has too many bugs I don't want to look into right now.
when release? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.