Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✅ Smart bound #339

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

✅ Smart bound #339

wants to merge 4 commits into from

Conversation

ZeroEkkusu
Copy link
Contributor

@ZeroEkkusu ZeroEkkusu commented Oct 31, 2022 •
edited
Loading

Description

Recommended update to smart bound:

  • Dictionary values: Do not modify input if within range, thus preserving dictionary values
  • Edge coverage: min, min + 1 2 3, & max, max - 1 2 3 covered (same as Forge)
  • Even distribution: Even better than before, ensuring no bias when warping inputs

Adopted from Forge Standard Library V1

Checklist

Ensure you completed all of the steps below before submitting your pull request:

  • Ran forge snapshot?
  • Ran npm run lint?
  • Ran forge test?

Pull requests with an incomplete checklist will be thrown out.

@transmissions11
Copy link
Owner

this looks great, thanks so much!

@transmissions11 transmissions11 changed the title feat: smart bound ✅ Smart bound Oct 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ZeroEkkusu @transmissions11