Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt to changes in the ADB ATO data source #20

Merged
merged 3 commits into from
Jun 18, 2024
Merged

Adapt to changes in the ADB ATO data source #20

merged 3 commits into from
Jun 18, 2024

Conversation

khaeru
Copy link
Contributor

@khaeru khaeru commented Jun 17, 2024

Closes #18.

In addition to the case mentioned in the issue description:

  • "-", meaning presumably "no data".

…I also discovered:

  • "41 226.2" —using a space as a thousands separator. The files as of 2023-04-17 contained only "," as a thousands separator.
  • "10860 .6" —space before a decimal separator.
  • "long ton" —apparently a unit descriptor copied into a data cell; sheet TAS-FRA-027 at Economy Code=MMR, TIME_PERIOD=2022. Note that this unit does not match the units annotation for the overall sheet.

@khaeru khaeru added ci Continuous integration & testing s:ADB ADB data provider labels Jun 17, 2024
@khaeru khaeru self-assigned this Jun 17, 2024
Copy link

codecov bot commented Jun 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.57%. Comparing base (d52312e) to head (1765e43).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #20      +/-   ##
==========================================
- Coverage   93.58%   93.57%   -0.01%     
==========================================
  Files          32       32              
  Lines        1184     1183       -1     
==========================================
- Hits         1108     1107       -1     
  Misses         76       76              
Files with missing lines Coverage Δ
transport_data/adb/__init__.py 94.54% <100.00%> (+0.05%) ⬆️

... and 2 files with indirect coverage changes

@khaeru khaeru merged commit 47e2c3a into main Jun 18, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Continuous integration & testing s:ADB ADB data provider
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adapt to changes in the ADB ATO data source
1 participant