Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tools/info for TUEWAS Asia project #21

Open
wants to merge 18 commits into
base: main
Choose a base branch
from
Open

Conversation

khaeru
Copy link
Contributor

@khaeru khaeru commented Jul 10, 2024

This PR collects improvements to the TDC tools made as part of the GIZ-funded TUEWAS project, covering 6 Asian countries:

  • CN China
  • ID Indonesia
  • IN India
  • PH Philippines
  • TH Thailand
  • VN Vietnam

Changes

  • Add a (provisional) TDC metadata structure for collecting information about data flows. This is a simplified version of the Eurostat ESMS.
  • New CLI commands and underlying code:
    • tdc org template: generate a "template" .xlsx file for collecting metadata.
    • tdc org read: read collected metadata from the file and summarize.
  • Add SDMX structural metadata, including for:
    • The 2006 IPCC guidelines on national GHG inventories.

How to review

Copy link

codecov bot commented Jul 10, 2024

Codecov Report

Attention: Patch coverage is 97.13376% with 9 lines in your changes missing coverage. Please review.

Project coverage is 94.06%. Comparing base (47e2c3a) to head (729b4ad).

Files with missing lines Patch % Lines
transport_data/org/cli.py 58.82% 7 Missing ⚠️
transport_data/ipcc/structure.py 99.05% 1 Missing ⚠️
transport_data/util/hooks.py 83.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #21      +/-   ##
==========================================
+ Coverage   93.57%   94.06%   +0.48%     
==========================================
  Files          32       38       +6     
  Lines        1183     1466     +283     
==========================================
+ Hits         1107     1379     +272     
- Misses         76       87      +11     
Files with missing lines Coverage Δ
transport_data/adb/__init__.py 94.64% <100.00%> (+0.09%) ⬆️
transport_data/adb/cli.py 65.38% <100.00%> (ø)
transport_data/iamc/__init__.py 97.75% <100.00%> (+0.07%) ⬆️
transport_data/jrc/__init__.py 93.18% <100.00%> (+0.07%) ⬆️
transport_data/jrc/cli.py 58.62% <100.00%> (ø)
transport_data/oica/__init__.py 97.22% <100.00%> (+0.03%) ⬆️
transport_data/oica/cli.py 61.53% <100.00%> (ø)
transport_data/org/__init__.py 100.00% <100.00%> (ø)
transport_data/org/metadata.py 100.00% <100.00%> (ø)
transport_data/testing.py 100.00% <100.00%> (ø)
... and 7 more

... and 1 file with indirect coverage changes

@khaeru khaeru self-assigned this Sep 6, 2024
@khaeru khaeru added doc Improvements or additions to documentation enh New feature or request labels Sep 6, 2024
- Add Git LFS configuration, .gitattributes.
- Add metadata specimen.
- Clone LFS files in "pytest" CI workflow.
- Add pluggy to dependencies.
- Define get_agencies() hook spec.
- Rename get_agency() to get_agencies() everywhere.
- Use hooks in .org.get_agencyscheme()
@khaeru khaeru mentioned this pull request Sep 20, 2024
1 task
- Add get_cs_common()
- Add getdefault()
- Add parse_dimension()
- Add summarize_metadatareport()
- Add update_dimension_descriptor()
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Improvements or additions to documentation enh New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant