Skip to content

Commit

Permalink
Fix Docker inconsistencies (#182)
Browse files Browse the repository at this point in the history
  • Loading branch information
No767 authored Aug 14, 2024
1 parent 1660cac commit 964886a
Show file tree
Hide file tree
Showing 6 changed files with 13 additions and 26 deletions.
12 changes: 7 additions & 5 deletions .github/workflows/docker.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,12 +3,15 @@ name: Docker
on:
push:
branches: [main]
tags:
- 'v*'
tags: ["v*"]

jobs:
Build-and-Push:
runs-on: ubuntu-latest

# We want to filter out dependabot and pre-commit
# automated pushes to main
if: ${{ github.actor != 'dependabot[bot]'}} && ${{ github.actor != 'pre-commit-ci[bot]'}}
steps:
- name: Checkout
uses: actions/checkout@v4
Expand Down Expand Up @@ -44,7 +47,6 @@ jobs:
context: .
file: ./docker/Dockerfile
push: true
cache-from: type=registry,ref=ghcr.io/${{ github.repository_owner }}/rodhaj:bot-build-cache
cache-to: type=registry,mode=max,ref=ghcr.io/${{ github.repository_owner }}/rodhaj:bot-build-cache
tags: ${{ steps.meta.outputs.tags }}
cache-from: type=registry,ref=ghcr.io/${{ github.repository_owner }}/rodhaj-build-cache:bot
cache-to: type=registry,mode=max,ref=ghcr.io/${{ github.repository_owner }}/rodhaj-build-cache:bot
labels: ${{ steps.meta.outputs.labels }}
7 changes: 2 additions & 5 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -31,11 +31,8 @@ jobs:


Release:
permissions:
contents: write
needs: Bundle

runs-on: ubuntu-latest
needs: Bundle
if: contains(github.event.head_commit.message, '#major') || contains(github.event.head_commit.message, '#minor') || contains(github.event.head_commit.message, '#patch')
steps:
- uses: actions/checkout@v4
Expand All @@ -52,7 +49,7 @@ jobs:
uses: anothrNick/[email protected]
id: tag_version
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
GITHUB_TOKEN: ${{ secrets.PAT_TOKEN }}
WITH_V: true
RELEASE_BRANCHES: main

Expand Down
4 changes: 2 additions & 2 deletions docker/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -7,10 +7,10 @@ ENV DEBIAN_FRONTEND=noninteractive

RUN apt-get update \
&& apt-get install -y --no-install-recommends \
tini \
bash \
netcat-traditional \
git \
netcat-traditional \
tini \
&& apt-get clean

WORKDIR /rodhaj
Expand Down
2 changes: 1 addition & 1 deletion docker/docker-compose.prod.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ name: rodhaj_prod
services:
rodhaj:
container_name: rodhaj
image: ghcr.io/transprogrammer/rodhaj:latest
image: ghcr.io/transprogrammer/rodhaj:edge
volumes:
# Do not edit the next line. If you want to change the path of the configuration file, please edit the CONFIG_LOCATION variable
- ${CONFIG_LOCATION}:/rodhaj/bot/config.yml
Expand Down
2 changes: 1 addition & 1 deletion docker/docker-compose.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ name: rodhaj
services:
rodhaj:
container_name: rodhaj
image: ghcr.io/transprogrammer/rodhaj:latest
image: ghcr.io/transprogrammer/rodhaj:edge
volumes:
# Do not edit the next line. If you want to change the path of the configuration file, please edit the CONFIG_LOCATION variable
- ${CONFIG_LOCATION}:/rodhaj/bot/config.yml
Expand Down
12 changes: 0 additions & 12 deletions envs/docker.env

This file was deleted.

0 comments on commit 964886a

Please sign in to comment.