Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

License changes #1

Merged
merged 1 commit into from
Oct 11, 2023
Merged

License changes #1

merged 1 commit into from
Oct 11, 2023

Conversation

skurhse
Copy link
Contributor

@skurhse skurhse commented Oct 10, 2023

  • Add license section to README.
  • Add MIT and Apache licenses.
  • Remove MPL license.

@skurhse skurhse requested a review from No767 October 10, 2023 22:46
@vprime
Copy link

vprime commented Oct 11, 2023

I think Apache & MIT options are typically good for this sort of project.

@skurhse skurhse merged commit b150fde into main Oct 11, 2023
5 checks passed
@skurhse skurhse deleted the license branch October 11, 2023 14:47
@No767
Copy link
Member

No767 commented Oct 11, 2023

I haven't had time to contribute my opinion, but the question remains why? What advantages and disadvantages does this bring, and what opportunity costs are we making. Apache-2.0 ultimately is just a more legally verbose version of the MIT license if I recall.

In short, I am unsure of the decision and that's why I kept it on my tab but not approving the review

@skurhse
Copy link
Contributor Author

skurhse commented Oct 11, 2023

I haven't had time to contribute my opinion, but the question remains why? What advantages and disadvantages does this bring, and what opportunity costs are we making. Apache-2.0 ultimately is just a more legally verbose version of the MIT license if I recall.

In short, I am unsure of the decision and that's why I kept it on my tab but not approving the review

The dual licensing is a pragma I took from the rust crates template. It's meant to empower the user to have more licensing options.

@skurhse
Copy link
Contributor Author

skurhse commented Oct 11, 2023

@No767
Copy link
Member

No767 commented Oct 11, 2023

see: https://internals.rust-lang.org/t/rationale-of-apache-dual-licensing/8952

I actually read this already. but thanks

@skurhse
Copy link
Contributor Author

skurhse commented Oct 11, 2023

here is the official answer: https://prev.rust-lang.org/en-US/faq.html#why-a-dual-mit-asl2-license

generally with licenses we want to go with a well-known, community-supported solution. I would personally be happy with just ASL2 if GPLv2 compatibility is not a concern. (probable)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants