Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken previous tag within release statements #184

Merged
merged 3 commits into from
Aug 14, 2024
Merged

Conversation

No767
Copy link
Member

@No767 No767 commented Aug 14, 2024

Summary

This PR aims to fix the old behavior of using the newly created tag by pulling the previous tag before the new one has been minted. For example, it used to be v0.1.0...v0.1.0, but now is actually v0.1.0...v0.2.0. This actually has been tested

Types of changes

What types of changes does your code introduce to Rodhaj
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (Updates to README.md, the documentation, etc)
  • Other (if none of the other choices apply)

Checklist

Put an x in the boxes that apply

  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes. (if appropriate)
  • All workflows (except pre-commit.ci) pass with my new changes
  • This PR does not address a duplicate issue or PR

Copy link

sonarcloud bot commented Aug 14, 2024

@No767 No767 merged commit 5a66cf5 into main Aug 14, 2024
10 checks passed
@No767 No767 deleted the noelle/release-fix branch August 14, 2024 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant