Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement permissions system #50

Merged
merged 20 commits into from
Jan 25, 2024
Merged

Implement permissions system #50

merged 20 commits into from
Jan 25, 2024

Conversation

No767
Copy link
Member

@No767 No767 commented Jan 21, 2024

Summary

This PR addresses #9, by implementing a permissions system with basic hierarchy checks. In addition, the permissions needed will also be displayed in the help command, allowing people to know what permissions they need in order to run the command. As a result, the help command is also being reformatted to accommodate for these changes. In addition, this PR also implements disabling allowed mentions for everyone/here and replied user mentions, and setting up the code to allow for custom prefix support

Before this PR can be merged, there are several items that need to be completed. Namely:

  • Implement permissions and injection system
  • Remove unused database columns pertaining to hierarchy checks
  • Remove perms injection for bot
  • Reformat group page to show permissions
  • Reformat group page in general
  • Document all permissions needed by the bot

Types of changes

What types of changes does your code introduce to Rodhaj
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (Updates to README.md, the documentation, etc)
  • Other (if none of the other choices apply)

Checklist

Put an x in the boxes that apply

  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes. (if appropriate)
  • All workflows (except pre-commit.ci) pass with my new changes
  • This PR does not address a duplicate issue or PR

No767 and others added 5 commits January 20, 2024 21:05
These checks allows extra permissions data to be injected into the command. This will be used for displaying what permissions are needed for the help command
@No767 No767 self-assigned this Jan 21, 2024
@No767 No767 linked an issue Jan 21, 2024 that may be closed by this pull request
@No767 No767 marked this pull request as ready for review January 25, 2024 01:55
Copy link

sonarcloud bot commented Jan 25, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@No767 No767 merged commit b9ae30b into main Jan 25, 2024
9 checks passed
@No767 No767 deleted the noelle/perms branch January 25, 2024 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Elimination of an hierarchal based permissions system
1 participant