Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove C build tools and upgrade PostgreSQL to 16 #72

Merged
merged 3 commits into from
Feb 7, 2024
Merged

Conversation

No767
Copy link
Member

@No767 No767 commented Feb 7, 2024

Summary

This removes the build tools required for compiling 3.12 compatible multidict wheels. In addition, the PostgreSQL version has been bumped to 16, thus this requires you to delete the previous volume associated and remake it. Simply backup any data needed, delete the previous volume, re-run the compose file and re-run the migrations.

Types of changes

What types of changes does your code introduce to Rodhaj
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (Updates to README.md, the documentation, etc)
  • Other (if none of the other choices apply)

Checklist

Put an x in the boxes that apply

  • If code changes were made then they have been tested.
    • I have updated the documentation to reflect the changes. (if appropriate)
  • All workflows (except pre-commit.ci) pass with my new changes
  • This PR does not address a duplicate issue or PR

The last project that depended on 312 wheels is multidict, and it seems like they finally released 312 wheels so we can remove gcc and libc6-dev as we don't need the c stdlib and gcc to compile the wheels
Copy link

sonarcloud bot commented Feb 7, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@No767 No767 merged commit eb85184 into main Feb 7, 2024
10 checks passed
@No767 No767 deleted the noelle/312-docker branch February 7, 2024 23:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant