Update README.md #1189
Draft
Update README.md #1189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added examples to show =ro flag and globbing, and that shows that globbing in fstab should not be escaped If it is, mergerfs manages to mount something that shows up with ????? in ls, and cant be accessed or doesn't contain anything. TODO for someone to explain why.
Added clarification to globbing section about fstab. Mergerfs not being able to use `\` literal might possibly be classified as a bug.
trapexit
reviewed
Jun 1, 2023
README.md
Outdated
| MUST be escaped when using via the shell else the shell itself will | ||
| apply the glob itself.** | ||
| apply the glob itself. Do not escape the glob in `fstab`. |
There was a problem hiding this comment.
This is implied by saying it must be done in the shell but sure... be explicit. But why remove the emphasis?
|
Please squash the commits and change the summary to be more descriptive. |
|
Also, the man page is created from the README. Please generate the man page and check it in at the same time. |
=RO examples in examples
More clear wording in `mv` section.
Make the biggest potentially devastating trap visible where it is much more likely to be seen in time.
Emphasis back to the note about globbing
|
I'm not at my own PC, and using Github web, will test the man pages and squash the commit when I'm home later in the week. I have to say, that man page is pretty neat! |
trapexit
force-pushed
the
latest-release
branch
from
a0a4401 to
5fba42f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed example lines to show =RO flag and globbing, and that emphasizes that globbing in fstab should not be escaped.
Also added comment about the trap of using
mvright at the beginning where it is hard to overlook, so as to lower the risk of people deleting their files by accident.