cleaning up the linux part: #14
Conversation
_ removing the need to use Xlib _adressing a few tweaks here and there
reverting changes for vla error as it it irrelevant for this pr. implementing the minimize and raise event and suspending app. tweaking keycode keysym to use hopefully more accurate keys.
There was a problem hiding this comment.
Hi! Thank you for submitting this, I appreciate the effort! Apologies it took me so long to get to it.
Unfortunately, these changes violate the pattern I am trying to enforce of keeping all platform-specific code (that is, windows/linux/etc) in it's respective platform c file. The key codes should be generic and engine-specific, and the fact that they align with the Windows platform is not much more than a coincidence. They should be translated in the platform layer from the platform-specific codes to the ones the engine uses, so that all other application code always uses the same keycodes regardless of what platform the engine is being run on.
I would be interested in the other changes though to only use xcb, so if you'd be willing to revisit this and make these changes I'd love to try it out.
You'll also want to update the branch, as I see there are conflicts.
I'll keep a closer eye out for updates to this. Thank you!
|
Sorry been a bit busy. I believe the changes should only take care of the issue this PR primarily aimed at resolving. |
_ removing the need to use Xlib
_adressing a few tweaks here and there
_temporary fix for "variable length array used" that caused an error on compile