Fix for windows #1812
Closed
Fix for windows #1812
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- In Windows environment, set the extension of the executable script to .ps1. - When specifying "powershell" for shell in a .dig file, the specification ["powershell.exe","-"] was used until digdag ver. 0.9.x. Since ver. 0.10, the "-" is no longer necessary. However, to ensure compatibility, the specification ["powershell.exe","-"] should be read as ["powershell.exe"].
|
I am wondering whether rewriting the task definiton of |
yoyama
reviewed
Sep 15, 2023
| List<String> temp_shell; | ||
| if (params.has("shell")) { | ||
| temp_shell = params.getListOrEmpty("shell", String.class); | ||
| if (temp_shell.get(0).toLowerCase().contains("powershell") && temp_shell.size() == 2){ |
There was a problem hiding this comment.
contains("powershell") will match to strings like 'powershell-batch.bat`. Is it intentional ?
yoyama
reviewed
Sep 15, 2023
| if (params.has("shell")) { | ||
| temp_shell = params.getListOrEmpty("shell", String.class); | ||
| if (temp_shell.get(0).toLowerCase().contains("powershell") && temp_shell.size() == 2){ | ||
| if (temp_shell.get(1).contains("-")){ |
There was a problem hiding this comment.
ditto. It will match like -option or abc-def.txt.
|
@yoyama , thank you for your review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sh> operator of v0.10.0 on Windows platform and compatibility
When specifying "powershell" for shell in a .dig file, the "powershell.exe" was
specified as ["powershell.exe","-"] until digdag ver. 0.9.x.
Since ver. 0.10 the "-" is no longer necessary.
However, for compatibility, the specification ["powershell.exe","-"]
should be read as ["powershell.exe"].
[WIP] Fix sh> operator issue on Windows #1654 is also included.